Skip to content

feat: Base data structures fot hook implementation.#112

Merged
NeaguGeorgiana23 merged 7 commits into
mainfrom
define-hook-data-structures
Jul 14, 2026
Merged

feat: Base data structures fot hook implementation.#112
NeaguGeorgiana23 merged 7 commits into
mainfrom
define-hook-data-structures

Conversation

@NeaguGeorgiana23

Copy link
Copy Markdown
Contributor

This PR

Introduces HookHints and FlagTypeValus that will allow later implementation of Hooks.

Related Issues

Fixes #111

Follow-up Tasks

Implementing the EvaluationOptions and HookData.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23
NeaguGeorgiana23 requested review from a team as code owners July 7, 2026 13:29
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aa0908c9-2a46-4352-b842-645d22bb6243

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc878b and 0e70a89.

📒 Files selected for processing (1)
  • openfeature/flag_type_value.h
🚧 Files skipped from review as they are similar to previous changes (1)
  • openfeature/flag_type_value.h

📝 Walkthrough

Walkthrough

This PR adds the FlagValueType enum class and HookHints type alias to the OpenFeature C++ SDK, along with header-only Bazel targets exposing both new headers.

Changes

New Type Definitions

Layer / File(s) Summary
FlagValueType enum
openfeature/flag_type_value.h, openfeature/BUILD
Defines openfeature::FlagValueType with boolean, string, integer, double, and object variants, and adds its header-only Bazel target.
HookHints type alias
openfeature/hook_hints.h, openfeature/BUILD
Defines openfeature::HookHints as an std::unordered_map<std::string, std::any> alias and adds its header-only Bazel target.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only adds HookHints and FlagValueType, but issue #111 also requires evaluation options, hook data, and hook context. Add the remaining hook data structures or clearly document that this PR only partially closes #111.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and relevant to the new hook-related base data structures.
Description check ✅ Passed The description matches the changes and mentions the hook-related follow-up work.
Out of Scope Changes check ✅ Passed The new headers and BUILD targets are all related to the hook-implementation groundwork.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23 NeaguGeorgiana23 changed the title base data structures fot hook implementation. feat: Base data structures fot hook implementation. Jul 7, 2026
NeaguGeorgiana23 and others added 2 commits July 7, 2026 13:56
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds foundational public types to support a future Hooks implementation in the OpenFeature C++ SDK, aligning with Issue #111’s “Hook hints” portion and preparing for later HookData/EvaluationOptions work.

Changes:

  • Introduces HookHints as a std::unordered_map<std::string, std::any> type alias.
  • Introduces FlagValueType enum to represent supported flag value categories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
openfeature/hook_hints.h Adds the HookHints type alias for passing arbitrary hook hint data.
openfeature/flag_type_value.h Adds the FlagValueType enum for flag value categorization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openfeature/flag_type_value.h Outdated
Comment thread openfeature/flag_type_value.h Outdated
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23
NeaguGeorgiana23 merged commit 91d1b13 into main Jul 14, 2026
5 checks passed
NeaguGeorgiana23 pushed a commit that referenced this pull request Jul 14, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.2](v0.1.1...v0.1.2)
(2026-07-14)


### Features

* Add HookContext class
([#115](#115))
([ec5a971](ec5a971))
* Add HookData class.
([#114](#114))
([fdac1e0](fdac1e0))
* Base data structures fot hook implementation.
([#112](#112))
([91d1b13](91d1b13))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook data structures

3 participants