Migrate threaded WASI loader to napi-rs 3.8 and emnapi v2 - #431
Draft
ishiko732 wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 75f5eb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## preview #431 +/- ##
========================================
Coverage 98.88% 98.88%
========================================
Files 76 76
Lines 2336 2336
Branches 573 573
========================================
Hits 2310 2310
Misses 24 24
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
@open-spaced-repetition/binding
ts-fsrs
@open-spaced-repetition/srs-kit
@open-spaced-repetition/binding-android-arm64
@open-spaced-repetition/binding-darwin-arm64
@open-spaced-repetition/binding-darwin-x64
@open-spaced-repetition/binding-linux-arm64-gnu
@open-spaced-repetition/binding-linux-arm64-musl
@open-spaced-repetition/binding-linux-x64-gnu
@open-spaced-repetition/binding-linux-x64-musl
@open-spaced-repetition/binding-wasm32-wasi
@open-spaced-repetition/binding-win32-arm64-msvc
@open-spaced-repetition/binding-win32-x64-msvc
commit: |
ishiko732
force-pushed
the
wasm32-wasip1-todo1
branch
from
July 29, 2026 07:54
f39b33a to
75f5eb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@napi-rs/cli3.8, wasm-runtime 1.2, and emnapi v2./dynamicwhile preserving./dynamic-wasias a same-file compatibility aliasWhy
The existing dynamic loaders were based on the older emnapi v1 runtime and no longer matched the lifecycle and plugin contracts generated by napi-rs CLI 3.8. Migrating them together avoids a runtime/loader version mismatch and removes the need to maintain separate CommonJS and ESM Node loaders.
Impact
@open-spaced-repetition/bindingnow requires Node.js 24 or newer../dynamic-wasiconsumers continue to work.wasm32-wasip1-threadsoutputs; threadless WASI and Cloudflare support remain follow-up work.pnpm dlx pkg-pr-new@0.0.79 publish.Validation
wasm32-wasip1-threadsrelease buildgit diff --check