test(html): render csv and zip in the output tests - #675
Merged
Conversation
andiwand
force-pushed
the
test/csv-output
branch
from
August 9, 2026 11:56
8363ba3 to
be8a75c
Compare
Both were skipped with a `TODO enable` next to them. Csv was skipped because it rendered as a line list, which was not worth pinning; it renders as a table now, so the skip has outlived its reason. Zip was skipped because there was no zip to render — the suite walks the input directory, and the public set had none. So the reference output gains what the two paths actually emit: `document.html` and `sheet0.html` for the csv, the one-sheet spreadsheet the generic renderer walks, and `files.html` for the zip. `zip/small.zip` is new input, and deliberately tiny — 271 bytes, two text files. An archive renders as a file listing with every entry inlined as a `data:application/octet-stream;base64` url, so a real-world archive would carry its whole content into the reference output. At this size the listing is 854 bytes and reviewable in a diff, while exercising the same code. Json stays skipped: it has no renderer of its own yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nk1S12YmjBsmksSJ4tVB3X
andiwand
force-pushed
the
test/csv-output
branch
from
August 9, 2026 11:57
be8a75c to
1a02e1b
Compare
andiwand
enabled auto-merge (squash)
August 9, 2026 11:59
andiwand
disabled auto-merge
August 9, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Fifth of the csv stack. Based on #669 — the value types change what a cell renders as, so the reference output has to be generated with them in.
Both csv and zip sat behind a
TODO enableinhtml_output_test.cpp, and for different reasons.Csv
Skipped because it rendered as a line list, which was not worth pinning. It renders as a table since #668, so the skip has outlived its reason. The reference output gains
document.htmlandsheet0.html— the one-sheet spreadsheet the generic renderer walks, capped at the suite's 4000 rows.Until now the only thing pinned for a csv was
meta.json, which is written before the skip. That is also why thedocumentTypeline reverted in #668 needed an output-repo commit of its own; it is folded into the same one here.Zip
Skipped because there was nothing to render.
get_test_fileswalks the input directory and maps by extension, and the public input set had no archive at all — so the skip was dead code.zip/small.zipis new input and deliberately tiny: 271 bytes, two text files.The reason for the size is
html/filesystem.cpp: an archive renders as a file listing and every entry becomes adata:application/octet-stream;base64,…download link (html/common.cpp:96). A real-world archive would carry its whole content into the reference output, base64-inflated. At this size the whole listing is 854 bytes and reads in a diff:Json stays skipped — no renderer of its own yet.
Data repositories
Both pins move, and both commits are on
mainof their repo:OpenDocument.test→d7c093da small zip to renderOpenDocument.test.output→e9aa12fzip: render the file listing, on top of33300e7csv: render as a tableVerification
Full suite, 815 passed / 8 skipped.
diff -rqof the generated tree against the reference is empty for both repos — the only files that moved are the three the two new renders produce.