8389539: Clarify equivalence class sizing with value objects - #32158
8389539: Clarify equivalence class sizing with value objects#32158jddarcy wants to merge 1 commit into
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| * classes. For value classes, there is not necessarily a similar | ||
| * constraint as multiple indistinguishable value objects could be | ||
| * constructed, depending on the semantics of the particular value | ||
| * class. |
There was a problem hiding this comment.
I would use the term "a single distinguishable element" instead of going into "multiple value objects" - "multiple" is an impression from the times when each constructor invocation creates a new distinguishable instance. Value objects are not necessarily constructed, either - in hotspot, you may load from a field twice and get two indistinguisable value objects, but another implementation may deduplicate them, and all these deduplication etc. are not visible to programs based on our specs.
Another update to Object.equals to better support value classes.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32158/head:pull/32158$ git checkout pull/32158Update a local copy of the PR:
$ git checkout pull/32158$ git pull https://git.openjdk.org/jdk.git pull/32158/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32158View PR using the GUI difftool:
$ git pr show -t 32158Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32158.diff
Using Webrev
Link to Webrev Comment