Skip to content

7904200: Several tests fail to run on Cygwin/Windows - #327

Open
raneashay wants to merge 1 commit into
openjdk:masterfrom
raneashay:CODETOOLS-7904200-cygwin-tests
Open

7904200: Several tests fail to run on Cygwin/Windows#327
raneashay wants to merge 1 commit into
openjdk:masterfrom
raneashay:CODETOOLS-7904200-cygwin-tests

Conversation

@raneashay

@raneashay raneashay commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This patch makes two changes. First, it strips the carriage-return
character from line endings before running grep to check for matches and
second, it broadens the file path regexes to accept both forward and
backward slashes. I validated this patch by running all tests
(bash make/build.sh -- tests) on both Windows and macOS.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/327/head:pull/327
$ git checkout pull/327

Update a local copy of the PR:
$ git checkout pull/327
$ git pull https://git.openjdk.org/jtreg.git pull/327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 327

View PR using the GUI difftool:
$ git pr show -t 327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/327.diff

Using Webrev

Link to Webrev Comment

This patch makes two changes.  First, it strips the carriage-return
character from line endings before running grep to check for matches and
second, it broadens the file path regexes to accept both forward and
backward slashes.  I validated this patch by running all tests
(`bash make/build.sh -- tests`) on both Windows and macOS.
@bridgekeeper

bridgekeeper Bot commented Jul 30, 2026

Copy link
Copy Markdown

👋 Welcome back arane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 30, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 30, 2026
@mlbridge

mlbridge Bot commented Jul 30, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant