feat(study_index): changes to study index required for rescaled effect computation - #1243
Open
project-defiant wants to merge 4 commits into
Open
feat(study_index): changes to study index required for rescaled effect computation#1243project-defiant wants to merge 4 commits into
project-defiant wants to merge 4 commits into
Conversation
project-defiant
changed the title
addramir
requested changes
Jun 24, 2026
Contributor
There was a problem hiding this comment.
Is it therapeuticAreaId for each of the diseseIds assaoited with the GWAS?
| return self.df.studyType == "gwas" | ||
|
|
||
| @staticmethod | ||
| def compute_prevalence(n_cases: Column, n_samples: Column, trait_class: Column) -> Column: |
Contributor
There was a problem hiding this comment.
We need a simple check somwhere that checks that n_cases+n_control=n_smaples. Otherwise this formula dosen't work
| quantitative rather than binary. | ||
| """ | ||
|
|
||
| EFO_0001444 = "measurement" |
Contributor
There was a problem hiding this comment.
Very dangerous part - we depend on EFO ontology here. They are going to change all of this in June - it won't work already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Context
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
devbranch?make test)?uv run pre-commit run --all-files)?