Skip to content

feat(client): Added Utils into menu - #472

Open
lukaskett wants to merge 1 commit into
mainfrom
feature/utils-generate-qr-relays
Open

feat(client): Added Utils into menu#472
lukaskett wants to merge 1 commit into
mainfrom
feature/utils-generate-qr-relays

Conversation

@lukaskett

@lukaskett lukaskett commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • I linked the related issue or explained why none is needed.
  • I ran the relevant checks for this change.
  • I updated documentation or changelog entries when needed.
  • By submitting this pull request, I agree to the terms in CLA.md in the
    repository root.

…pdf with qr codes for identifying competitors in relays events, #258
@martinkrivda
martinkrivda force-pushed the feature/utils-generate-qr-relays branch from 3f9f50b to 88e9509 Compare July 24, 2026 12:40

@martinkrivda martinkrivda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change tested before opening the PR?

The form component is missing entirely, so the current import cannot be resolved and the application will not build correctly. Please either remove the import if the component is no longer needed, or add the missing component file and verify the change locally before updating the PR.

The tests cover encoding and the validation schema, but not the missing form, the PDF creation flow, or the route. Once the component is added, I would include at least a component test for successful PDF generation and a test for the PDF error path.

import { Card } from '@/components/ui/card';
import { useTranslation } from 'react-i18next';
import { MainPageLayout } from '../../../templates/MainPageLayout';
import { QrCodeGeneratorForm } from './QrCodeGeneratorForm';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot find module './QrCodeGeneratorForm' or its corresponding type declarations.ts(2307)

@lukaskett

Copy link
Copy Markdown
Contributor Author

Ou, weird, i probably made something wrong, sorry. It was tested...I will check it and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants