Resolve issues where the ISO3166 countries regex doesn't match. - #541
Open
plambrechtsen wants to merge 2 commits into
Open
Resolve issues where the ISO3166 countries regex doesn't match.#541plambrechtsen wants to merge 2 commits into
plambrechtsen wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for reporting this issue. We've created an internal issue tracking this and will look at including it in a future release of the provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 4 country codes that are missing from the regex that is used by addresses and notification templates.
Also
ANshould be removed from the listI found this while extracting the current configuration and attempting to import it using Terraform.
Also corrected a few sorting values to get them in order.
There are 3 locations that the country code is specified.
To me it would make sense to replace all 3 with an enum ref, and use a simplified regex of:
But when I tried that it created double quotes around one of the strings in the openapi yaml that gets generated so rolled that back.