Skip to content

fix: update tree pattern expand icon direction#12554

Merged
thatblindgeye merged 4 commits into
patternfly:mainfrom
mcoker:issue-12553
Jul 17, 2026
Merged

fix: update tree pattern expand icon direction#12554
thatblindgeye merged 4 commits into
patternfly:mainfrom
mcoker:issue-12553

Conversation

@mcoker

@mcoker mcoker commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

fixes #12553

Updates the following tree patterns to use the right/down arrows instead of down/up

Summary by CodeRabbit

Summary

  • Bug Fixes

    • Updated expand/collapse toggle indicators in Tree View, Dual List Selector, and table tree rows to use the correct right-facing caret icon for the expanded state.
  • Style

    • Refreshed PatternFly styling dependencies by moving to the latest matching 6.6.0 prerelease build to keep UI visuals consistent.

@mcoker
mcoker requested review from kmcfaul and thatblindgeye July 10, 2026 01:00
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f2177e03-7008-4fa8-83ee-313417259ef4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updates five PatternFly package references to 6.6.0-prerelease.20 and changes tree expand/collapse toggle icons from caret-down to caret-right in TreeView, DualListSelector, and table tree rows.

Changes

Tree caret and PatternFly updates

Layer / File(s) Summary
PatternFly prerelease dependency alignment
packages/react-core/package.json, packages/react-docs/package.json, packages/react-icons/package.json, packages/react-styles/package.json, packages/react-tokens/package.json
Pins @patternfly/patternfly dependencies or devDependencies to 6.6.0-prerelease.20.
Tree toggle caret updates
packages/react-core/src/components/{TreeView,DualListSelector}/*, packages/react-table/src/components/Table/utils/decorators/treeRow.tsx
Replaces rendered caret-down toggle icons with RhMicronsCaretRightIcon and updates the corresponding imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: jcmill, thatblindgeye

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the tree expand icon direction change and matches the main code change.
Linked Issues check ✅ Passed The tree view caret was updated to the right icon, matching the linked issue's collapsed-state direction requirement.
Out of Scope Changes check ✅ Passed The other tree-pattern and dependency updates are still related to the same icon-direction work, not unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should we also update where wew're using a tree view outside the actual component, like the DualListSelector with tree implementation?

@mcoker mcoker changed the title fix(tree-view): update expand icon direction fix: update tree pattern expand icon direction Jul 15, 2026
@mcoker
mcoker requested a review from thatblindgeye July 15, 2026 20:28
@mcoker

mcoker commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@thatblindgeye nice catch. Confirmed with design, all tree patterns should be updated. Updated the PR so it changes:

Need to merge the CSS change from patternfly/patternfly#8502 for this PR to look right, since that changes the rotation from 180deg to 90deg.

@jcmill jcmill left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thatblindgeye
thatblindgeye merged commit 8c89c01 into patternfly:main Jul 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update treeview expand icon

4 participants