SBP Milestone III review

[ayushmishra2005]

General remarks

---

1. README instructions should be much clear about testing the functionality of the pallet.
2. Pallet name looks more generic. It should be more specific like what it is exactly doing.
3. NO unit test-cases. Unit test-cases must be there for all dispatchable functions for all scenarios.
4. Strong recommendation to run cargo fmt to improve formatting
5. Strong recommendation to run cargo clippy to remove warnings and improve codebase.
6. DO NOT write dispatchable function for fetching item from storage. The correct way is either to define a getter on a storage item, or to create a custom RPC method.
   For more details, please go through below links :

How to declare storage items in Substrate
Remote procedure calls
Add custom RPC to the node