Skip to content

i18n(ja): fix false-friend mistranslations of mirror and local - #23466

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-false-friend-mirror-local
Open

i18n(ja): fix false-friend mistranslations of mirror and local#23466
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-false-friend-mirror-local

Conversation

@yahonda

@yahonda yahonda commented Aug 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Two English words were mistranslated using their wrong homonym sense in 5 sites across 5 files:

  • "mirror" (the TiUP package-repository concept) was rendered as 鏡 (the literal glass object), contradicting 190 other corpus sites that correctly use ミラー, and contradicting each affected file's own frontmatter summary (both already said ミラー). Fixed in tiup/tiup-command-mirror.md and tiup/tiup-command-mirror-sign.md, also restoring a dropped は particle in the former.
  • "local" was rendered as 地元 ("hometown/native place") in three unrelated contexts:
    • grafana-tikv-dashboard.md: a TiKV Grafana panel heading "Local Reader," contradicting the correct ローカルリーダー used in the very next line of body text.
    • tidb-lightning/tidb-lightning-overview.md: a data-source list item "Local" (as in local filesystem).
    • tiup/tiup-component-cluster-template.md: the literal --local CLI flag name, which had also lost its double-dash syntax and picked up a stray leading dash (- 地元 instead of --local). Restored to the literal English flag name, matching its sibling --full/--multi-dc headings in the same file.

Also restores two untranslated cloud-provider proper nouns to English, matching the overwhelming corpus convention (Amazon S3: 484 occurrences, Google Cloud Storage: 82) and each file's own body text immediately below the affected heading, which already correctly kept them in English:

  • tidb-lightning/tidb-lightning-overview.md: a data-source list item (アマゾンS3Amazon S3, GoogleクラウドストレージGoogle Cloud Storage).
  • tidb-cloud/serverless-export.md: two section headings, same two terms.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

N/A

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b6a53971-35a4-4c37-85b8-386ac66331dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2026
Two English words were mistranslated using their wrong homonym sense
in 5 sites across 5 files:

- "mirror" (the TiUP package-repository concept) was rendered as the
  literal glass object, contradicting the 190 other corpus sites that
  correctly use the katakana loanword, and contradicting each file's
  own frontmatter summary (both already said the katakana form).
  Fixed in tiup/tiup-command-mirror.md and tiup/tiup-command-mirror-sign.md,
  also restoring a dropped は particle in the former.
- "local" was rendered as "hometown/native place" in three unrelated
  contexts: a TiKV Grafana panel heading ("Local Reader," contradicting
  the correct katakana form used in the very next line of body text),
  a TiDB Lightning data-source list item ("Local," as in local
  filesystem), and a tiup CLI flag reference heading (the literal flag
  name "--local," which had also lost its double-dash syntax and picked
  up a stray leading dash). Fixed in grafana-tikv-dashboard.md,
  tidb-lightning/tidb-lightning-overview.md, and
  tiup/tiup-component-cluster-template.md (the last one restored to the
  literal English flag name, matching its sibling --full/--multi-dc
  headings in the same file).

Also restores two untranslated cloud-provider proper nouns to English
in two files, matching the overwhelming corpus convention (484 and 82
occurrences respectively) and each file's own body text immediately
below the affected heading, which already correctly kept them in
English:
- tidb-lightning/tidb-lightning-overview.md: a data-source list item.
- tidb-cloud/serverless-export.md: two section headings.
@yahonda
yahonda force-pushed the i18n-ja-false-friend-mirror-local branch from 6a27e1f to 1952117 Compare August 7, 2026 07:40
@yahonda
yahonda marked this pull request as ready for review August 7, 2026 07:43
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant