fix: remove duplicate packages/bot, fix remaining build breaks - #944
Conversation
…llstack#943) - Delete packages/bot/* (unpublished, unreferenced duplicate of packages/bots/*, zero external consumers) so pnpm -r build no longer compiles the dead tree — fixes the repeated TS2345 failures described in profullstack#943/profullstack#942 - bots/core: annotate finish() with AIResult instead of a widened inline type (TS2345: type string not assignable to "result") - bots/signal: fix outdated test object (groupId undefined→null, drop non-existent raw field, add isGroup)
|
🤖 Auto-rebase failed: This branch has conflicts with |
3 similar comments
|
🤖 Auto-rebase failed: This branch has conflicts with |
|
🤖 Auto-rebase failed: This branch has conflicts with |
|
🤖 Auto-rebase failed: This branch has conflicts with |
Fixes #943
packages/bot/*is an abandoned, unpublished duplicate ofpackages/bots/*with zero external consumers (the only references are the five packages pointing at each other). It is still compiled bypnpm -r build, so defects there break the workspace build for everyone — exactly what happened in #942.Changes
packages/bot/*entirely (core/discord/signal/telegram/whatsapp — the dead tree). No code references it: no package.json depends on@sh1pt/bot-*, no tsconfig/CI referencespackages/bot.packages/bots/core: annotatefinish()withAIResultinstead of a widened inline type — fixesTS2345: type 'string' not assignable to type '"result"'.packages/bots/signal: fix outdated test object —groupId: undefined → null, drop non-existentrawfield, add requiredisGroup.Verification
pnpm -r build: all packages Done, zero failures (was: bot/core + bots/core + bots/signal failing)tsc -p tsconfig.json --noEmitclean in bots/core and bots/signal