fix(cli): add check=True to ensure-libvirt-session-config + timeout=10 to urlopen calls - #15
Merged
Merged
Conversation
…0 to urlopen calls Fixes two pre-existing bugs reported in issue #12: - setup_vms: subprocess.run missing check=True on ensure-libvirt-session-config, causing false success when the config script fails - changelogs: urlopen calls missing timeout, hanging forever when GitHub unreachable Also bumps release.yml to Python 3.14 (closes renovate PR #2). Assisted-by: Claude Sonnet 4.6 via GitHub Copilot CLI Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pre-existing bugs from issue #12.
Bug 1: setup_vms prints success even when libvirt session config fails
subprocess.run(['/usr/libexec/ensure-libvirt-session-config']) had no check=True. Added check=True so a non-zero exit propagates as CalledProcessError instead of silently printing 'VM stack ready'.
Bug 2: changelogs hangs indefinitely when GitHub is unreachable
Both urlopen calls had no timeout. Added timeout=10 to each. socket.timeout is a subclass of urllib.error.URLError so existing error handlers catch it.
Also applies the Python 3.14 CI bump from renovate PR #2 (which has a merge conflict) so that PR can be closed.
Closes #12