docs(agents): add AGENTS.md and integrate bonedigger into factory model - #17
docs(agents): add AGENTS.md and integrate bonedigger into factory model#17castrojo wants to merge 2 commits into
Conversation
Assisted-by: Claude Sonnet 4.6 via GitHub Copilot CLI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hanthor
left a comment
There was a problem hiding this comment.
LGTM — AGENTS.md and factory model integration are well-structured. Note: has a merge conflict that needs resolving before merge.
hanthor
left a comment
There was a problem hiding this comment.
Switching from BONEDIGGER_SYNC_TOKEN PAT to the mergeraptor GitHub App token is a clear security improvement — scoped to specific repos, auditable, and rotatable. Action pinned by digest. Note: the repositories: list in create-github-app-token is hardcoded; if a new downstream repo is added it must be updated in sync with the matrix. AGENTS.md is well-structured and follows the factory contract format. LGTM.
hanthor
left a comment
There was a problem hiding this comment.
Switching from BONEDIGGER_SYNC_TOKEN PAT to the mergeraptor GitHub App token is a clear security improvement — scoped per-repo, auditable, rotatable. Action pinned by digest. One note: the repositories: list in create-github-app-token is hardcoded; adding a new downstream repo requires updating both the token scope and the matrix in sync. AGENTS.md is well-structured and follows the factory contract format. LGTM.
ReviewVerdict: Needs Changes Critical (blocks merge)
Important (should fix)
Strengths
NotesNo CI checks reported for the branch — expected for a docs + workflow-only PR if the workflow trigger is Recommendation: Add the |
…TS.md Assisted-by: claude-sonnet-4.6 via pi
hanthor
left a comment
There was a problem hiding this comment.
Review: Changes requested
The AGENTS.md addition itself is excellent content. However, there are blockers:
-
Merge conflicts — branch is 11 commits behind
main, mergeable_state is dirty. -
Regressive changes — if merged as-is, the PR would revert improvements already on
main:.github/workflows/sync-templates.yml: uses floating@v4tag (main has SHA-pinned@v6), missingconcurrencygroup, usessecrets.MERGERAPTOR_APP_IDinstead ofvars.MERGERAPTOR_APP_IDdocs/skills/bonedigger-overview.mdanddocs/skills/bonedigger-templates.md:ublue-os→projectbluefinandknuckleadditions are already on main
Recommendation: Rebase on latest main, then drop changes to these 3 files (.github/workflows/sync-templates.yml, both skill docs). Keep only the AGENTS.md addition. Then run:
pre-commit run --all-files
actionlint .github/workflows/*.yml
hanthor
left a comment
There was a problem hiding this comment.
This PR currently has merge conflicts with the base branch and can't be merged as-is. Could you rebase / resolve the conflicts? Happy to re-review once it's mergeable — the change itself looks reasonable.
Summary
AGENTS.mdwith bonedigger's factory contract, issue lifecycle, labels, local validation, and CI/CD integration pointsprojectbluefin/*downstream repos and the app-token auth modelTest plan
Closes #13
Closes projectbluefin/common#418