cleanup: remove dead keyboard/language/timezone wizard steps - #194
Open
castrojo wants to merge 1 commit into
Open
cleanup: remove dead keyboard/language/timezone wizard steps#194castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
hanthor
requested changes
Jun 21, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Merge conflicts — needs rebase on main. The cleanup itself (removing ~650 lines of dead wizard code) is correct and well-scoped. Please rebase and re-push to trigger CI.
These modules implemented full wizard steps but were never registered in builder.py and never applied to the installed system. Removing to reduce maintenance surface and confusion. Closes #187 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castrojo
force-pushed
the
feature/187-remove-dead-locale-steps
branch
from
June 30, 2026 02:22
e43e482 to
0e11e90
Compare
castrojo
pushed a commit
that referenced
this pull request
Jun 30, 2026
…, branch note - dev.sh -> run-dev.sh (renamed on main branch) - Remove keymaps.py, keyboard.py, language.py, timezone.py from module map (removed by PR #194) - Remove test_timezone.py from GTK test examples (removed by PR #194) - Mark dead-code quality finding as resolved - Add note: PRs targeting main bypass CI — check manually with gh pr checks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
✅ Flatpak manifests validated successfully
|
hanthor
approved these changes
Jul 1, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Review: Approved ✅
Clean dead code removal. Verified:
- 22 files deleted (2564 lines removed, 0 added) — correct pattern
BootcDefaultKeyboard,BootcDefaultLanguage,BootcDefaultTimezoneare not imported anywherecore/keymaps.py,core/languages.py,core/timezones.pyhave no remaining importsdinosaurs.jsononly loaded by dead timezone module- All 6 Blueprint UI files, gresource.xml refs, and meson entries consistently removed
- 4 dead test files removed
- Zero remaining references across the repo
PR mergeable and conflict-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes defaults/{keyboard,language,timezone}.py and related core helpers, Blueprint UI files, and data (dinosaurs.json). These implemented full wizard steps but were never registered in builder.py and never applied to the installed system.
Tests: 398 passed, 2 skipped. Ruff clean on changed files.
Closes #187