fix(ci): make merge queue lane build-only in build.yml - #826
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe build workflow now skips image promotion, pushing, digest handling, and manifest creation for ChangesMerge queue gating
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
common#660 skipped the image export and CVE scan for merge_group, but the promote/push/digest/manifest steps still ran on != 'pull_request' (which includes merge_group). The promote step read the never-exported /tmp/scan-image.tar and failed, ejecting every merge queue entry since 2026-07-06 (PRs 802, 815, 817, 824, 825 all hit it). Exclude merge_group from every push-lane step so the queue lane only verifies the combined commit builds. Registry pushes, digests, manifests, and signing remain exclusive to the push/dispatch lanes. Assisted-by: Claude Fable 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8c4a4a8 to
9d592bd
Compare
Root cause
The merge queue has silently ejected every entry since 2026-07-06 (PRs #802, #815, #817, #824, #825 — nothing has merged in two weeks). common#660 added
if: github.event_name != 'merge_group'to the Export image for scanning and Scan image for CVEs steps, but left these on!= 'pull_request'(which matches merge_group):/tmp/scan-image.tar, which the skipped export never produced:open /tmp/scan-image.tar: no such file or directory(failing merge-group run):latestfrom a throwaway queue ref if the promote step hadn't failed firstFix
Merge queue lane is now build-only: every push-lane step carries
github.event_name != 'pull_request' && github.event_name != 'merge_group'. The queue verifies the combined commit builds; pushing, digests, manifests, and signing stay exclusive to the push/dispatch lanes.Self-healing: merge_group runs execute the workflow from the merged ref, so this PR's own queue run uses the fixed YAML.
Skill update (same PR)
docs/skills/ci-tooling.mdmerge_group section extended with the build-only rule and the artifact-lane tracing checklist.Validation
just check: passUnblocks #824 (MIME defaults) and #825 (game-devices-udev checksum), plus the stalled Renovate queue.
Summary by CodeRabbit
Bug Fixes
Documentation