fix(ujust): bootstrap fzf for --choose - #902
Open
castrojo wants to merge 4 commits into
Open
Conversation
Install the Homebrew-managed chooser on demand when --choose runs before brew-preinstall completes. Assisted-by: GPT-5 via pi
- Match --choose as an exact argument instead of joined-string search - Propagate brew shellenv failure before dispatching just - Verify fzf is resolvable after shellenv and fail closed - Strengthen test_ujust.bats with isolated PATH, fake fzf via shellenv, install→shellenv→just ordering, and negative paths Assisted-by: Claude via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Register the ujust Bats coverage in just test and document why the fzf bootstrap is needed before brew-preinstall completes. Assisted-by: GPT-5.6 Luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castrojo
added
agent/contributor
castrojo
requested review from
a team,
ahmedadan,
hanthor,
inffy,
ledif and
repires
as code owners
July 31, 2026 16:19
Assisted-by: GPT-5.6 Luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Make
ujust --choosebootstrap the Homebrew-managedfzfdependency when it is not yet available, then initialize the Homebrew environment before invokingjust. Register focused Bats coverage injust testand document the early-login behavior.Why?
fzfis installed bybrew-preinstall.service, so it can be missing when a user invokesujust --choosebefore the first login setup completes.Closes #899
Testing
bash -n system_files/shared/usr/bin/ujustgit diff --checkpassedjust test/just checkcould not run becausebats,just, andpre-commitare unavailable in this environmentChecklist
just checkpassespre-commit run --all-filespassesgh run list --repo projectbluefin/common --limit 5AI attribution
Assisted-by: GPT-5.6 Luna via GitHub Copilot
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
🐝 Hive Agent:
contributor| SHA:unknown