fix(disk): increase /boot partition from 1 GiB to 2 GiB - #7
Conversation
Each kernel+initramfs pair can be 200-400 MiB with large driver sets (e.g. NVIDIA). With a running deployment, a staged upgrade, and a rollback entry, 1 GiB fills up quickly. 2 GiB provides comfortable headroom and matches the systemd-boot layout which already uses 2 GiB.
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
LGTM. Clean 2-line change with solid rationale. CI failures are pre-existing nilerr/lvm issues unrelated to this PR.
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
LGTM. Clean 2-line change with solid rationale. CI failures are pre-existing nilerr/lvm issues unrelated to this PR. Ready to merge.
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
LGTM. Clean 2-line change with solid rationale. CI failures are pre-existing nilerr/lvm issues unrelated to this PR.
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
Review: Changes requested
The partition size change (1 GiB → 2 GiB) is correct and well-motivated. However, the test TestPartition_SfdiskScript in partition_test.go still asserts size=1GiB and will fail with this change. Please update the test assertion to expect size=2GiB.
2 participants
Each kernel+initramfs pair can be 200-400 MiB with large driver sets (e.g. NVIDIA). With a running deployment, a staged upgrade, and a rollback entry, 1 GiB fills up quickly.\n\n2 GiB provides comfortable headroom and matches the systemd-boot layout which already uses 2 GiB for the same reason.