chore(deps): update dependency golangci/golangci-lint to v2.12.2 - #214
Merged
Conversation
castrojo
requested changes
May 23, 2026
castrojo
left a comment
Collaborator
There was a problem hiding this comment.
Code Review — REQUEST CHANGES ❌
Issue: Justfile line 55 still pins GOLANGCI_LINT_VERSION := "2.11.4" but ci.yml is now bumped to v2.12.2. These two must stay in sync per the project rule:
Tool version bumps — update
GOLANGCI_LINT_VERSIONin Justfile AND.github/workflows/ci.ymltogether, thenjust tools && just ci.
Running just tools after this PR lands will reinstall golangci-lint at v2.11.4 (the Justfile value), conflicting with CI which uses v2.12.2.
Fix: Add to this PR:
- GOLANGCI_LINT_VERSION := "2.11.4"
+ GOLANGCI_LINT_VERSION := "2.12.2"One-line change to Justfile. Happy to approve immediately after.
Matches the ci.yml bump from Renovate. Tool version pins must stay in sync between Justfile and .github/workflows/ci.yml. Assisted-by: Claude claude-sonnet-4-5 via pi
castrojo
approved these changes
May 23, 2026
castrojo
left a comment
Collaborator
There was a problem hiding this comment.
Justfile GOLANGCI_LINT_VERSION synced to 2.12.2 in the branch. Both Justfile and ci.yml now pinned at v2.12.2. ✅
castrojo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.11.4→v2.12.2Release Notes
golangci/golangci-lint (golangci/golangci-lint)
v2.12.2Compare Source
Released on 2026-05-06
gomodguard_v2: fix blocked configurationgomodguard_v2: from 2.1.0 to 2.1.3iface: from 1.4.1 to 1.4.2v2.12.1Compare Source
Released on 2026-05-01
gomodguard_v2: fix panic with migration suggestioninstall.shscript (if you are still using an URL based on the branchmaster, please update to usehttps://golangci-lint.run/install.sh)v2.12.0Compare Source
Released on 2026-05-01
clickhouselintlinter https://github.com/ClickHouse/clickhouse-go-linterdupl: fromf665c8dtoc99c5cf(extended detection)funcorder: from 0.5.0 to 0.6.0 (new option:function)goconst: add an option to ignore strings from testsgoconst: from 1.8.2 to 1.10.0 (extended detection)gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)gosec: from619ce21to 2.26.1 (new checks:G124,G708,G709,G710)govet: addinlineanalyzermakezero: from 2.1.0 to 2.2.1 (support slice type aliases)paralleltest: exposecheckcleanupoptionsloglint: from 0.11.1 to 0.12.0 (new options:allowed-keys,custom-funcs)wsl_v5: from 5.6.0 to 5.8.0 (new option:cuddle-max-statements; new checks:after-decl,after-defer,after-expr,after-go,cuddle-group)forbidigo: from 2.3.0 to 2.3.1godot: from 1.5.4 to 1.5.6govet-modernize: from 0.43.0 to 0.44.0ireturn: from 0.4.0 to 0.4.1rowserrcheck: from 1.1.1 toc5f79b8customcommandConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.