Prefer parent uri when matching uri#682
Merged
Merged
Conversation
mnauw
force-pushed
the
uri_match_parent
branch
from
December 27, 2025 14:20
f6542bf to
edce2fc
Compare
Contributor
Author
|
Looks like the Mac runners are down, should otherwise be OK now (with prior glitch for Windows case handling). |
ccordoba12
changed the title
ccordoba12
approved these changes
Jul 18, 2026
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks @mnauw!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present,
match_uri_to_workspacecan return a workspace that is not a parent of the uri. In particular, if/a/b/cis a workspace, and also/a/b, then searching for a workspace for/a/b/x/ycan return either one of the previous. In this case, however,/a/bis preferred as it is actually a parent (whereas/a/b/cis not). While this may be an "odd" workspace setup, it can occur when dealing with git submodules or some other project setup (also depending on the LSP client). But presumably it is preferable to be robust at the LSP server end than to declare such invalid.