Fix types of maxComplexity and line_length#703
Merged
Conversation
Member
|
Closing and reopening to rerun our tests. |
ccordoba12
approved these changes
Jul 18, 2026
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Thanks @krassowski!
Note: I don't know what's happening with the Mac tests but let's hope they're fixed when merging to develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
flake8.maxComplexity(default wasnullbut it was not included in the types array)line_length(wasnumberbut should have beenintegeras fractional line count does not make sense)