Skip to content

Make Ukrainian locale name follow ISO 639, update it and add tests #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nykula wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make Ukrainian locale name follow ISO 639, update it and add tests #957

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3258088
Make Ukrainian locale name follow ISO, update it and add tests
nykula Apr 3, 2026
56769c8
Add Ukrainian test suggested by @afastronomer, and fix formatting
nykula Apr 12, 2026
d07a06c
Keep only 'uk', not 'ua', as discussed with @Secrus
nykula Jul 3, 2026
fd45ad8
Remove forgotten test assert about 'ua' backward compatibility
nykula Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pendulum/locales/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ def normalize_locale(cls, locale: str) -> str:
if m:
return f"{m.group(1).lower()}_{m.group(2).lower()}"
else:
return locale.lower()
lower = locale.lower()
if lower == 'ua':
# Backward compatibility. Ukrainian was 'ua' initially.
lower = 'uk'
return lower
Comment thread
nykula marked this conversation as resolved.
Outdated

def get(self, key: str, default: Any | None = None) -> Any:
if key in self._key_cache:
Expand Down
281 changes: 0 additions & 281 deletions src/pendulum/locales/ua/locale.py
View file
Open in desktop

This file was deleted.

0 src/pendulum/locales/ua/__init__.py → src/pendulum/locales/uk/__init__.py
View file
Open in desktop
File renamed without changes.
46 changes: 23 additions & 23 deletions src/pendulum/locales/ua/custom.py → src/pendulum/locales/uk/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
"""
ua custom locale file.
"""
from __future__ import annotations
translations = {
"units": {"few_second": "кілька секунд"},
# Relative time
"ago": "{} тому",
"from_now": "за {}",
"after": "{0} посіля",
"before": "{0} до",
# Date formats
"date_formats": {
"LTS": "HH:mm:ss",
"LT": "HH:mm",
"L": "DD.MM.YYYY",
"LL": "D MMMM YYYY р.",
"LLL": "D MMMM YYYY р., HH:mm",
"LLLL": "dddd, D MMMM YYYY р., HH:mm",
},
}
"""
uk custom locale file.
"""
from __future__ import annotations


translations = {
"units": {"few_second": "кілька секунд"},
# Relative time
"ago": "{} тому",
"from_now": "через {}",
"after": "через {0}",
"before": "{0} тому",
# Date formats
"date_formats": {
"LTS": "HH:mm:ss",
"LT": "HH:mm",
"L": "DD.MM.YYYY",
"LL": "D MMMM YYYY",
"LLL": "D MMMM YYYY, HH:mm",
"LLLL": "ddd, D MMMM YYYY, HH:mm",
},
}
Loading
Loading