Windows mise support - #683
Open
dealenx wants to merge 3 commits into
Open
Conversation
The Windows mise release archive contains mise/bin/mise.exe (unversioned), but the extractor matched against the versioned output filename returned by getBinaryName(). Match both the versioned output name and the plain archive name on Windows so extraction succeeds.
filepath.Dir/Join/IsAbs/Base are host-OS dependent and convert forward slashes to backslashes on Windows, corrupting Linux container paths (e.g. /etc/mise/config.toml became \etc\mise). Use forward-slash logic in convertFileCommandToLLB and the path package in resolvePaths so generated container paths stay POSIX regardless of the host OS.
iloveitaly
requested changes
Aug 10, 2026
iloveitaly
left a comment
iloveitaly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution. I'd love to get this in. I think there's a couple of improvements you can make to reduce the code complexity here, but otherwise, this looks good.
I want to add some basic integration tests for Windows on GitHub Actions as well, but that's a bit separate from this pull request.
| // Create parent directories for the file | ||
| parentDir := filepath.Dir(cmd.Path) | ||
| // Create parent directories for the file. The container always runs Linux, so | ||
| // container paths must stay POSIX-style. filepath.Dir is host-OS dependent and |
Collaborator
There was a problem hiding this comment.
is there a reason parentDir := path.Dir(cmd.Path) wouldn't work?
| // the versioned output name or the plain archive name so both layouts are handled. | ||
| var archiveNames []string | ||
| if runtime.GOOS == "windows" { | ||
| archiveNames = []string{getBinaryName(), "mise.exe"} |
Collaborator
There was a problem hiding this comment.
why do we need an array here? we should be able to leave this alone and just update the binary name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context - #404
Support
misefor Windows 11 OSProblem before
Demo
The releases to test: https://github.com/dealenx/railpack/releases/tag/v0.35.1