differentiate between overtaking cars and bikes - #5
Open
PaulaScharf wants to merge 3 commits into
Open
Conversation
Member
Author
|
And maybe the values of overtaking and surface classification should be shown as X% and not 0.X |
Member
Author
|
|
Member
Author
|
I just tested and uploading the overtaking bike and car percentage to OSM is not working. The other sensors work. Not sure how to fix, might try later |
Contributor
|
Per discussion with @PaulaScharf , I am keeping this PR open for the future references. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this makes it not compatible with the current atrai senseBox:bikes on the OSM, cause its registered as an additional sensor. Maybe also allow senseBox:bikes without an "Overtaking Bike" Sensor.
Also idk if the visualization is good or the icon should be changed. Maybe the legend text should be bigger, so that it fills the tile