Add new interfaces to enable intropsection for action - #2743
Merged
fujitatomoya merged 2 commits intoMar 12, 2025
Merged
Conversation
This was referenced Feb 14, 2025
Barry-Xu-2018
force-pushed
the
review/topic-action-configure-introspection
branch
from
March 4, 2025 05:03
aa85eb3 to
b9db4bd
Compare
Barry-Xu-2018
marked this pull request as ready for review
March 4, 2025 05:04
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
force-pushed
the
review/topic-action-configure-introspection
branch
from
March 10, 2025 08:52
b9db4bd to
84ac6f5
Compare
Collaborator
Author
|
Rebase was done. |
fujitatomoya
self-requested a review
March 11, 2025 05:49
Collaborator
|
@Barry-Xu-2018 i will review this tomorrow. |
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
almost lgtm. a nitpick, and a couple of comments to confirm.
Signed-off-by: Barry Xu <barry.xu@sony.com>
Collaborator
Author
|
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
|
ahcorde
approved these changes
Mar 12, 2025
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
* Add new interfaces to enable intropsection for action Signed-off-by: Barry Xu <barry.xu@sony.com> * Correct some comments Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ros-infrastructure/rep#405
Depend on ros2/rcl#1207