Fix remote pipeline shader reflection retrieval - #2
Open
samtou-arm wants to merge 1 commit into
Open
Conversation
Serialize remote ShaderReflection pointers as opaque uint64 values and resolve them through a proxy-local RPC. Cache the resulting reflections by pointer value, avoiding reconstruction of backend-specific GetShader parameters and correctly handling shader replacements across APIs.
samtou-arm
changed the base branch from
v1.x
to
feat/RENDERDOC-716/fix_shader_source
August 7, 2026 15:34
samtou-arm
changed the base branch from
feat/RENDERDOC-716/fix_shader_source
to
v1.x
August 7, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialise remote ShaderReflection pointers as opaque uint64 values and resolve them through a proxy-local RPC. Cache the resulting reflections by pointer value, avoiding reconstruction of backend-specific GetShader parameters and correctly handling shader replacements across APIs.
This PR aims to address the maintainer's comment on this upstream PR: baldurk#3879
Basically, my understanding of the approach is:
Point of attention:
It's all tested on Windows + Linux (D3D11, D3D12, Vulkan and OpenGL) in both ways (Windows remote server then Linux remote server).