Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bucket_id support #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Adding bucket_id support #97
Changes from all commits
f0032fe5d553523e41d893b96172815beb079c55aaf2c0c7eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 85 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.
Check warning on line 147 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 184 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 233 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 239 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Provide the parametrized type for this generic.
Check warning on line 259 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "shardingOptions" which hides the field declared at line 100.
Check warning on line 303 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "T" which hides a type parameter from the outer scope.
Check warning on line 303 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
T is not used in the method.
Check warning on line 303 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 318 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 318 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "T" which hides a type parameter from the outer scope.
Check warning on line 318 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
T is not used in the method.
Check warning on line 344 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 344 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
T is not used in the method.
Check warning on line 344 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "T" which hides a type parameter from the outer scope.
Check warning on line 356 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "T" which hides a type parameter from the outer scope.
Check warning on line 356 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
T is not used in the method.
Check warning on line 356 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 379 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 379 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
Check warning on line 379 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Rename "T" which hides a type parameter from the outer scope.
Check warning on line 379 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
T is not used in the method.
Check warning on line 419 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Replace this instanceof check and cast with 'instanceof FilteringObserver filteringobserver'
Check warning on line 423 in src/main/java/io/appform/dropwizard/sharding/DBShardingBundleBase.java
Replace this instanceof check and cast with 'instanceof ListenerTriggeringObserver listenertriggeringobserver'
Check warning on line 36 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 40 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 46 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 48 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 50 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 52 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 54 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 62 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 64 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 66 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 68 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 70 in src/main/java/io/appform/dropwizard/sharding/dao/operations/OpContext.java
Replace generic exceptions with specific library exceptions or a custom exception.
Uh oh!
There was an error while loading. Please reload this page.