Skip to content

fix: ci lint - #1762

Merged
yiweichi merged 1 commit into
developfrom
fix-lint
Nov 25, 2025
Merged

fix: ci lint#1762
yiweichi merged 1 commit into
developfrom
fix-lint

Conversation

@yiweichi

@yiweichi yiweichi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Purpose or design rationale of this PR

This PR fix the ci lint failure.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Summary by CodeRabbit

Release Notes

  • Style
    • Minor internal code formatting adjustment with no impact on user-facing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 25, 2025

Copy link
Copy Markdown

Walkthrough

A long comment in the GetFirstUnuploadedBatchByPlatform function was reformatted to span multiple lines for improved readability. No logic or control flow changes were made.

Changes

Cohort / File(s) Change Summary
Comment formatting
rollup/internal/controller/blob_uploader/blob_uploader.go
Wrapped a long comment across two lines in GetFirstUnuploadedBatchByPlatform without altering logic or semantics

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A comment so long, it stretched far and wide,
The rabbit said, "Let's make this easier on the eyes!"
With two gentle lines, the meaning remains,
Readability blooms through the code's veins. 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: ci lint' follows conventional commits format and accurately describes a CI linting fix, which aligns with the actual changes (comment wrapping for lint compliance).
Description check ✅ Passed The description includes the purpose (fixing CI lint failure), follows the required template structure, and has all checkboxes properly completed with relevant selections (style type, no version tag update, not a breaking change).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-lint

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ede0cd and 839ada9.

📒 Files selected for processing (1)
  • rollup/internal/controller/blob_uploader/blob_uploader.go (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-29T16:38:24.647Z
Learnt from: colinlyguo
Repo: scroll-tech/scroll PR: 1714
File: rollup/internal/controller/relayer/l2_relayer.go:1548-1555
Timestamp: 2025-07-29T16:38:24.647Z
Learning: In rollup/internal/controller/relayer/l2_relayer.go, the validateBatchFields function should error out when GetBatchByHash fails to find a parent batch. This is intentional behavior - missing parent batches represent genuine error conditions that should halt batch submission processing. Genesis batch handling occurs separately from normal batch validation flow.

Applied to files:

  • rollup/internal/controller/blob_uploader/blob_uploader.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: check
  • GitHub Check: tests
  • GitHub Check: tests
🔇 Additional comments (1)
rollup/internal/controller/blob_uploader/blob_uploader.go (1)

245-246: LGTM!

The comment has been properly wrapped to comply with line-length linting rules while maintaining readability and preserving the original intent. This is an appropriate fix for the CI lint failure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.54%. Comparing base (0ede0cd) to head (839ada9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1762   +/-   ##
========================================
  Coverage    36.54%   36.54%           
========================================
  Files          247      247           
  Lines        21186    21186           
========================================
  Hits          7742     7742           
  Misses       12614    12614           
  Partials       830      830           
Flag Coverage Δ
rollup 35.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread rollup/internal/controller/blob_uploader/blob_uploader.go
@yiweichi
yiweichi merged commit 9100a0b into develop Nov 25, 2025
6 checks passed
@yiweichi
yiweichi deleted the fix-lint branch November 25, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants