chore(deps-dev): bump eslint from 8.57.1 to 10.5.0 - #21
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.5.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.5.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.5.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| "@types/react": "^19", | ||
| "@types/react-dom": "^18", | ||
| "eslint": "^8", | ||
| "eslint": "^10", |
There was a problem hiding this comment.
🔥 The Roast: Bumping eslint from 8 to 10 like it's a minor patch. ESLint 10 ships with a strict Node.js engine requirement (^20.19.0 || ^22.13.0 || >=24) that's completely unenforced in this repo — no .nvmrc, no engines field, just a CI step that happens to use Node 20. Also, ESLint 10 defaults to flat config, which means your cozy .eslintrc.json is now on probation. If next lint doesn't explicitly opt into legacy mode, those rules might silently vanish into the flat config void.
🩹 The Fix:
- Add an
enginesfield topackage.jsonto enforce the Node.js floor locally:
"engines": {
"node": ">=20.19.0"
}- Verify
npm run lintstill loads.eslintrc.jsoncorrectly. If it silently drops to an empty flat config, either migrate toeslint.config.jsor setESLINT_USE_FLAT_CONFIG=falsein the lint script.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review Roast 🔥Verdict: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The lockfile regenerated without integrity issues — npm didn't have a nervous breakdown. 💀 Worst part: Major ESLint version bump in a project that has zero local Node.js version enforcement and a legacy config format. 📊 Overall: Like upgrading from a bicycle to a rocket engine — the engine is better, but you haven't checked if the bike frame can handle the thrust. Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash-20260528 · Input: 112.4K · Output: 31.5K · Cached: 2.4M |
Bumps eslint from 8.57.1 to 10.5.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
de3b67210.5.0362a518Build: changelog update for 10.5.05ca8c52feat: correct stack tracking in max-nested-callbacks (#20973)b565783feat: report no-with violations at the with keyword (#20971)2ce032ffeat: report max-lines-per-function violations at function head (#20966)732cb3efeat: report max-nested-callbacks violations at function head (#20967)f9c138afeat: report max-depth violations on keywords (#20943)8ae1b5bdocs: Update READMEca7eb90docs: update Node.js prerequisites to include ICU support (#20962)b18bf58chore: update ecosystem plugins (#20959)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)