clear initialization SQL after running it on the async prepare path - #492
Merged
Conversation
PrepareAsync executed the queued initialization scripts but never drained the queue, so every later transaction in the same session re-ran all previously registered scripts. Add initializationSqlScripts.Clear() to match the existing Prepare() method. Adds an async regression test that registers the same script each outer transaction and asserts it executes exactly once per transaction.
Collaborator
Author
|
issue discovered by @botinko relates to servicetitan/app#139430 |
dagreen-st
commented
Jul 29, 2026
botinko
approved these changes
Jul 30, 2026
SergeiPavlov
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrepareAsync executed the queued initialization scripts but never drained
the queue, so every later transaction in the same session re-ran all
previously registered scripts. Add initializationSqlScripts.Clear() to
match the existing Prepare() method.
Adds an async regression test that registers the same script each outer
transaction and asserts it executes exactly once per transaction.