Pro: tag each message-info feature row for QA - #2166
Merged
Conversation
The message details screen lists the Session Pro features a message was sent with, but the rows carried no identifier — so an automated test could only match them by their localized text, which breaks on any wording or translation change and cannot say which feature a row is. Tag each row with a per-feature id, named from the per-message subset of the shared Pro feature vocabulary so one feature is called the same thing wherever it appears. The strings are a cross-platform contract: iOS defines the same values in SessionProUI.AccessibilityIdentifier and Desktop derives them from its own feature list, so one Appium locator serves all three.
Bilb
force-pushed
the
feature/qa-tags-pro-message-features
branch
from
August 18, 2026 00:29
71bf449 to
283170b
Compare
mpretty-cyro
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message details screen lists the Session Pro features a message was sent with, but the rows carried no identifier — so an automated test can only match them by their localized text. That breaks on any wording or translation change, and it cannot distinguish which feature a row is without hard-coding three strings.
This tags each row with a per-feature id, via the existing
Modifier.qaTag+content-descriptionsmechanism:PRO_BADGEpro-message-feature-badgesHIGHER_CHARACTER_LIMITpro-message-feature-longer-messagesANIMATED_AVATARpro-message-feature-animated-display-pictureThe names are the per-message subset of the shared Pro feature vocabulary (the same words the Pro settings surface uses —
longer-messages,badges,animated-display-picture), so one feature is called the same thing wherever it appears rather than gaining a second name per screen.These strings are a cross-platform contract: the matching PRs give iOS the same values in
SessionProUI.AccessibilityIdentifierand Desktop derives them from its ownProFeatureItemslist, so one Appium locator serves all three clients.No behaviour change —
qaTagonly adds a Compose test tag.Verified with
./gradlew :app:compilePlayAutomaticQaKotlin(BUILD SUCCESSFUL).