ci: gate the Aminet upload behind manual approval - #19
Merged
Conversation
Restructure release.yml following amiauth's release process: the `release` job verifies tag/version.mk/readme/$VER agreement, rebuilds and validates the archive (validate-only, no upload), creates the GitHub Release, and stashes the unversioned pair as an artifact; a new `aminet` job in the approval-gated `aminet` environment (required reviewer) then FTPs the package to Aminet only after explicit approval in the Actions UI. aminet-upload.yml becomes the retry path for lapsed approvals or failed uploads; CLAUDE.md's stale "Aminet upload is still manual" note updated to describe the gated flow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the release process in line with amiauth's, most importantly the approval-gated Aminet upload:
release.yml→ two jobs. Thereleasejob runs automatically on tag push: verifies the tag againstversion.mk, the readme'sVersion:line, and the$VER:strings inside the builtnarrator.device/translator.library; rebuilds the archive in CI; validates the readme (validate-only: true— no upload); creates the GitHub Release with versioned copies; and stashes the unversioned lha + readme as a workflow artifact.aminetjob runs in theaminetenvironment (required reviewer, already created on this repo), so it pauses until approved on the Actions run page, then FTPs the artifact to Aminet. No rebuild at approval time — a days-later rebuild would stamp a different$VERdate than the release assets. NoGITHUB_TOKENis passed, so the action skips attach-to-release and doesn't duplicate the versioned assets.aminet-upload.yml— comment-only update: it's now the retry path for lapsed approvals (pending deployments expire after 30 days) or failed uploads.CLAUDE.md— the versioning section's "Aminet upload is still manual" note was already stale; now describes the gated flow.Test plan
actionlintclean on both workflowsmake -s versionprints44.0(feeds the new tag-verification step)aminetenvironment exists with required reviewer configuredmake release+git push --follow-tags(v44.0)🤖 Generated with Claude Code