Represent ESC character in inline snapshots. - #231
Open
zainab-ali wants to merge 1 commit into
Open
Conversation
zainab-ali
commented
Jul 13, 2026
| case '\n' => "\\n" | ||
| case '\r' => "\\r" | ||
| case '\t' => "\\t" | ||
| case '\u001B' => "" |
Contributor
Author
There was a problem hiding this comment.
This is now treated as non-readable ASCII below. There are no issues writing to patch files or updating snapshots.
I suspect the case '\u001B' => "" logic was from pprint, which was designed for terminal output.
zainab-ali
marked this pull request as ready for review
July 13, 2026 13:16
majk-p
approved these changes
Jul 13, 2026
zainab-ali
force-pushed
the
non-readable-ascii
branch
from
July 13, 2026 14:54
6138814 to
49add1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #204