fix(codex): correct reported context token metadata - #151
Open
mossgowild wants to merge 1 commit into
Open
Conversation
Owner
|
I am not merging this PR for now because I analyzed how VS Code currently handles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150
Summary
reportedMaxOutputTokensso VS Code can receive output-token metadata for context window display without sendingmax_output_tokensto provider APIsgpt-5.5as272000input tokens with a reported128000output reserveWhy
VS Code/Copilot uses
maxInputTokensas the prompt budget for extension-contributed language models. Reporting an oversized Codex input budget can cause VS Code to include too much context and send requests beyond the real Codex API input limit.At the same time, Codex OAuth should not receive explicit
max_output_tokens, so output-reserve metadata needs to be reported separately from the request parameter source.Validation
npm run compilenpm run l10n:check