You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dx-2808-seth-config-serialization-fixsmartcontractkit/chainlink-testing-framework:dx-2808-seth-config-serialization-fixCopy head branch name to clipboard
dx-2808-seth-config-serialization-fixsmartcontractkit/chainlink-testing-framework:dx-2808-seth-config-serialization-fixCopy head branch name to clipboard
To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.
Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes TOML serialization of Seth’s Config by excluding runtime-only fields that are not intended to be persisted (and can be non-serializable), improving reliability for operations like config copying and any TOML marshaling.
Changes:
Marked Config runtime-only fields (RPCHeaders, ethclient, Hooks) with toml:"-" so they are omitted from TOML encoding/decoding.
Added a changeset entry documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File
Description
seth/config.go
Excludes non-persistable/runtime-only fields from TOML serialization via struct tags.
seth/.changeset/v1.51.7.md
Release note entry for the config serialization fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and...:
golangci-lintversion