p-token: Add unsafe qualifier to validate owner - #66
Merged
Conversation
febo
force-pushed
the
febo/unsafe-validate-owner
branch
from
July 9, 2025 09:54
cdf6cc3 to
f82f939
Compare
febo
marked this pull request as ready for review
July 9, 2025 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
validate_ownerhelper function has specific safety requirements to avoid undefine behaviour: theowner_account_infocannot be mutably borrowed. At the same time, the function is not qualified asunsafe.Solution
Add the
unsafequalifier to the function and update every callsite.cc: @d0nutptr