Fix #5415: add new KafkaConsumerRecodItemStreamReader - #5454
Open
djechelon wants to merge 1 commit into
Open
Conversation
Split KafkaItemReader into base implementation and alternate implementation that returns whole message envelope Copy same test from KafkaItemReaderTests into KafkaConsumerRecordItemReaderTests Add few test code to KafkaItemReaderBuilderTests Signed-off-by: /usr/local/ΕΨΗΕΛΩΝ <djechelon@zighinetto.org>
Contributor
|
|
Author
|
About that, consider also that Refactoring Jms and Amqp would mean that the |
Contributor
We could deprecate current reader and add new readers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #5415, goal is to implement a new Kafka-based ItemReader that returns not only the message body (generic V), but the whole envelope (as ConsumerRecord<K,V>).
In order to maintain backwards compatibility, the following has been done:
Please consider that locally I am experiencing
mvn verifyeven on main as I started working on the fork. I was able to verify that my affected tests work, failing tests occur on unaffected classes.I wish to thank whoever will spend their precious time paying attention to this contribution.