Skip to content

Fixing the JSpecify Annotations for Encoding in StaxEventItemReader - #5483

Open
Gorock wants to merge 1 commit into
spring-projects:mainfrom
Gorock:FIX_Stax_Jspecify_Annotations
Open

Fixing the JSpecify Annotations for Encoding in StaxEventItemReader#5483
Gorock wants to merge 1 commit into
spring-projects:mainfrom
Gorock:FIX_Stax_Jspecify_Annotations

Conversation

@Gorock

@Gorock Gorock commented Aug 6, 2026

Copy link
Copy Markdown

The encoding can be null Based on the Javadoc but Jspecify gives a warning when passing null. Which is confusing

this is my first Contribution to Spring Batch so please tell me if i forget something.

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission
  • Sign-off commits according to the Developer Certificate of Origin

For more details, please check the contributor guide.
Thank you upfront!

the encoding can be null based on the Documentation but Jspecify gives a warning when passing null. Which is confusing

Signed-off-by: Daniel Morady <7807967+Gorock@users.noreply.github.com>
@Gorock
Gorock force-pushed the FIX_Stax_Jspecify_Annotations branch from d743965 to 5360c70 Compare August 6, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant