fixed ite in msat with mixed int and real - #505
Open
osankur wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a small issue for MathSAT. This is illustrated in the newly added test tests/msat/msat-real-arithmetic.cpp.
Basically, the following calls create terms with types, respectively, integer and rational:
In other terms, MathSAT seems to recognize when a value simplifies to an integer and converts it to an integer.
But when two such terms are used in a ite expression with the
ext_msat_make_itefunction, this raises an exception since the two terms have different sorts.To comply with MathSAT's behavior, and to allow working with real numbers that happen to be integers, this commit allows mixing real and int expressions in ITE expressions.