test: reproduce #5850 — "No procedure found on path external.openInApp" - #5854
Draft
github-actions[bot] wants to merge 1 commit into
Draft
test: reproduce #5850 — "No procedure found on path external.openInApp"#5854github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the bug is
Clicking Open in App (sidebar button or
CMD+O) shows a toast:instead of opening the worktree in the chosen editor/IDE (IntelliJ IDEA in the report).
Root-cause diagnosis
The desktop has two tRPC backends for a workspace:
externalrouter withopenInApp/openInFinder/openFileInEditor), reached over the local IPC transport (trpc-electron).@superset/host-serviceappRouter), reached over HTTP at/trpc/*(served by@hono/trpc-server→fetchRequestHandler). This router has noexternalnamespace at all (seepackages/host-service/src/trpc/router/router.ts).The two transports emit different not-found messages for a missing path:
callProcedureNo "mutation"-procedure on path "…"resolveResponseNo procedure found on path "…"The reporter's text is the HTTP variant — proof that the
external.openInAppcall reached the host-service router (which doesn't implement it) rather than the local Electron router that does.What the test does / how it proves the bug
packages/host-service/test/integration/external-open-in-app.integration.test.tsdrives the real host-serviceappRouterthroughfetchRequestHandler(the same adapter the host-service serves with):external.openInApp→ HTTP 404,code: NOT_FOUND, message exactlyNo procedure found on path "external.openInApp"— reproducing the reported error at its source.health.checkresolves normally, confirming the router is served correctly and the failure is specific to the missingexternalnamespace.Both tests pass (
bun testinpackages/host-service).Why this is reproduction-only (draft)
The exact error and its source are reproduced deterministically. However, I could not tie it to a live UI code path on
main: every current "Open in App" /CMD+Ocaller routes the mutation to the local Electron client (which implementsexternal.openInApp), and remote/host workspaces are guarded (V2WorkspaceOpenInButtonrenders only for local workspaces,useOpenInExternalEditorand the command-paletteopenInprovider both short-circuit non-local hosts). So the reporter's build/state most likely routed the call to the host-service in a way current source no longer does.This test therefore (a) reproduces and localizes the exact error, and (b) acts as a regression guard documenting that open-in must never be routed to the host-service HTTP router.
Maintainers: please confirm the installed build and whether the affected workspace was local or hosted on another machine, so the fix can target the correct routing guard.
Refs #5850
Summary by cubic
Added an integration test in
packages/host-service/test/integration/external-open-in-app.integration.test.tsthat reproduces #5850 by callingexternal.openInAppagainst the host-service HTTP tRPC endpoint (fetchRequestHandler), returning the exact error:No procedure found on path "external.openInApp". This confirms the failure originates from the host-service router (not the Electronexternalrouter) and documents the expected 404, serving as a regression guard.Written for commit 7029301. Summary will update on new commits.