Fix macOS Accessibility trust across Preview rebuilds - #509
Merged
Conversation
Contributor
Author
|
@greptileai please review the latest commit and provide a full score. |
Greptile SummaryThe PR stabilizes macOS Accessibility authorization across Preview rebuilds by introducing a local development-signing workflow and revising permission verification. It also moves certificate-signed Preview pairing tokens into a new Keychain namespace.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| cross-platform/scripts/setup-macos-dev-signing.sh | Creates and reuses the machine-local code-signing identity used to keep the Preview bundle requirement stable. |
| cross-platform/scripts/run-macos-signed.sh | Builds the signed debug application, verifies its certificate-based designated requirement, and launches it. |
| cross-platform/src-tauri/src/macos.rs | Adds explicit Accessibility evaluation, input-adapter initialization, Settings navigation, and readiness transitions. |
| cross-platform/src-tauri/src/lib.rs | Rechecks required Accessibility access whenever the main macOS window regains focus. |
| cross-platform/src-tauri/src/state.rs | Restores only pairing records backed by tokens available in the active Keychain namespace and presents re-pairing guidance. |
| cross-platform/src-tauri/src/storage.rs | Assigns certificate-signed macOS Preview builds a separate pairing-token Keychain service. |
| cross-platform/src/App.tsx | Updates permission status and recovery controls to reflect the new macOS Accessibility workflow. |
| .github/workflows/cross-platform.yml | Keeps macOS CI bundles unsigned while retaining normal Windows bundle generation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Launch signed macOS Preview] --> B[Create Enigo without prompting]
B -->|Success| C[Store input adapter]
C --> D[Accessibility: Granted]
B -->|Permission unavailable| E[Accessibility: Required]
E --> F[User opens Accessibility Settings]
F --> G[Request permission and open exact pane]
G --> H[Window regains focus]
H --> B
Reviews (3): Last reviewed commit: "Scope pairing keychain migration to macO..." | Re-trigger Greptile
Contributor
Author
|
Local permission verification update:
Android-to-TextEdit input smoke testing remains manual. |
Contributor
Author
|
@greptileai please review the latest commit af4fadc and provide a full score. |
Contributor
Author
|
@greptileai please review the latest commit f7d9e45 and provide a full score. |
enaboapps
marked this pull request as ready for review
August 5, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #508
What changed
Validation
npm run lintnpm test(6 tests)npm run buildcargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warningscargo test --manifest-path src-tauri/Cargo.toml(58 unit tests + config test)Android-to-TextEdit typing, click, movement, modifier, and scrolling remain a manual device smoke test.