Keep the macOS cursor overlay alive at screen edges - #511
Draft
enaboapps wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@greptileai please review the latest commit 5bc3dbf and provide a full score. |
Greptile SummaryThe PR keeps the macOS cursor overlay worker alive when the pointer does not belong to a display’s half-open frame.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The new lookup preserves contained-point ownership, deterministically resolves otherwise unmatched coordinates, safely returns None for an empty screen list, and is compatible with the repository’s pinned Rust toolchain.
|
| Filename | Overview |
|---|---|
| cross-platform/src-tauri/src/overlay_macos.rs | Replaces strict display containment with containment-or-nearest selection and adds comprehensive pure geometry tests; no actionable defect was identified. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Read macOS cursor position] --> B{Point inside a half-open screen frame?}
B -- Yes --> C[Use containing screen]
B -- No --> D{Any screens available?}
D -- No --> E[Return resolution error]
D -- Yes --> F[Compute squared distance to each frame]
F --> G[Use nearest screen; first screen wins ties]
C --> H[Render and position overlay]
G --> H
Reviews (1): Last reviewed commit: "Keep macOS overlay alive at screen edges" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
What changed
Root cause
An exact upper or right boundary coordinate matched no NSScreen. The resulting render error terminated the cursor-overlay worker, so moving away from the edge could not restore it.
Validation
The live pointer edge/corner smoke check is pending because the Mac desktop was locked when Computer Use attempted to inspect the launched app.