drivers: fix task state reported to on_task_change on ttl - #257
Open
bigbes wants to merge 1 commit into
Open
Conversation
In the "ttl tasks" loop of the fifottl and utubettl driver fibers the loop
variable shadowed the 'state' module:
for _, state in pairs(ttl_states) do
...
task = self:delete(task[i_id]):transform(2, 1, state.DONE)
Inside the loop `state` is a status string, so `state.DONE` indexes a string,
evaluates to nil, and `transform(2, 1, nil)` sets the status field to NULL
instead of DONE. The task passed to the user's on_task_change callback with
the 'ttl' event was therefore malformed.
Rename the loop variable to `task_state`.
Closes #255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "ttl tasks" loop of the fifottl and utubettl driver fibers the loop variable shadowed the 'state' module. Inside the loop
stateis a status string, sostate.DONEindexes a string, evaluates to nil, andtransform(2, 1, nil)sets the status field to NULL instead of DONE. The task passed to the user's on_task_change callback with the 'ttl' event was therefore malformed. Rename the loop variable totask_state.Closes #255