-
Notifications
You must be signed in to change notification settings - Fork 229
fix: release please configs #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
87197f3
fix: release please configs
Stromweld 574395c
add codeowners
Stromweld 61bf936
test
Stromweld 28db79d
test
Stromweld b1c904a
test
Stromweld 90be8f5
Merge remote-tracking branch 'origin/main' into fix-release-please
Stromweld 181b7aa
updates
Stromweld 65263c5
fix cookstyle
Stromweld 1e75911
update rubocop to use cookstyle
Stromweld aaf2889
linting fixes
Stromweld 16c73b6
test cinc changes
Stromweld 9cc9c05
test
Stromweld 31c83b0
test
Stromweld f9346b8
fix load errors
Stromweld 298e4dd
cleanup
Stromweld fc29d0e
test
Stromweld 630a13b
test
Stromweld 4287e84
test
Stromweld 8eb0326
test
Stromweld 8edfead
test
Stromweld 4bf074d
test
Stromweld 4fad74c
test
Stromweld b5764a3
test
Stromweld 5090794
test
Stromweld 28058b5
test
Stromweld 60c157d
test
Stromweld 7fa6f06
fix: remove Docker Buildx step from Windows CI job
Stromweld fc265b0
test
Stromweld 6519d26
fix: use host OS detection for Docker socket configuration
Stromweld 7d3de58
fix: use Windows containers for Windows CI integration test
Stromweld 1a949ea
fix: set cinc_omnibus_root for Windows container platform
Stromweld a91e7b7
tes
Stromweld 9b43694
fix: skip InSpec verify for Windows container (cinc_auditor uses WinR…
Stromweld 9743ef2
test
Stromweld d8f3c6f
fix: remove install_strategy override for Windows platform (inherit g…
Stromweld 1d4edad
fix spec location
Stromweld 27f9270
test
Stromweld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @test-kitchen/maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| --- | ||
| default: true | ||
| MD004: false | ||
| MD012: false | ||
| MD013: false | ||
| MD024: false | ||
| MD026: false | ||
| MD036: false | ||
| MD012: false | ||
| MD029: false | ||
| MD004: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| ".": "3.2.2" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| --- | ||
| require: | ||
| - chefstyle | ||
| - cookstyle/chefstyle | ||
|
|
||
| AllCops: | ||
| TargetRubyVersion: 3.1 | ||
| Include: | ||
| - "**/*.rb" | ||
| Exclude: | ||
| - "vendor/**/*" | ||
| - "spec/**/*" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,22 @@ | ||
| source 'https://rubygems.org' | ||
| source "https://rubygems.org" | ||
|
|
||
| gemspec | ||
|
|
||
| group :development do | ||
| gem 'kitchen-inspec', '~> 3.0' | ||
| gem 'train', '>= 2.1', '< 4.0' # validate 4.x when it's released | ||
| # Integration testing gems. | ||
| gem "kitchen-cinc-auditor", git: "https://github.com/test-kitchen/kitchen-cinc-auditor.git" | ||
| gem "cinc-auditor-bin", source: "https://rubygems.cinc.sh" | ||
| gem "kitchen-cinc" | ||
| gem "train", ">= 2.1", "< 4.0" # validate 4.x when it's released | ||
| end | ||
|
|
||
| group :test do | ||
| gem 'bundler' | ||
| gem 'rake' | ||
| gem 'rspec', '~> 3.2' | ||
| gem 'rspec-its', '~> 2.0' | ||
| gem "bundler" | ||
| gem "rake" | ||
| gem "rspec", "~> 3.2" | ||
| gem "rspec-its", "~> 2.0" | ||
| end | ||
|
|
||
| group :chefstyle do | ||
| gem 'chefstyle', '~> 2.2', '>= 2.2.3' | ||
| group :cookstyle do | ||
| gem "cookstyle" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,19 @@ | ||
| require "bundler/gem_tasks" | ||
|
|
||
| # Create the spec task. | ||
| require "rspec/core/rake_task" | ||
| RSpec::Core::RakeTask.new(:test, :tag) do |t, args| | ||
| t.rspec_opts = [].tap do |a| | ||
| a << "--color" | ||
| a << "--format #{ENV["CI"] ? "documentation" : "progress"}" | ||
| a << "--backtrace" if ENV["VERBOSE"] || ENV["DEBUG"] | ||
| a << "--seed #{ENV["SEED"]}" if ENV["SEED"] | ||
| a << "--tag #{args[:tag]}" if args[:tag] | ||
| a << "--default-path test" | ||
| a << "-I test/spec" | ||
| end.join(" ") | ||
| RSpec::Core::RakeTask.new(:unit) | ||
|
|
||
| desc "Run all unit tests" | ||
| task test: %i{unit} | ||
|
|
||
| begin | ||
| require "cookstyle/chefstyle" | ||
| require "rubocop/rake_task" | ||
| RuboCop::RakeTask.new(:style) do |task| | ||
| task.options += ["--display-cop-names", "--no-color"] | ||
| end | ||
| rescue LoadError | ||
| puts "cookstyle/chefstyle is not available. (sudo) gem install cookstyle to do style checking." | ||
| end | ||
|
|
||
| task default: %i{style test} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| test/cookbooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,94 @@ | ||
| # <% # Make sure the local copy of the driver is loaded %> | ||
| # <% lib = File.expand_path('../lib', __FILE__) %> | ||
| # <% $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) %> | ||
| --- | ||
| driver: | ||
| name: docker | ||
| provision_command: curl -L https://www.chef.io/chef/install.sh | bash | ||
| provision_command: curl -L https://omnitruck.cinc.sh/install.sh | bash | ||
|
|
||
| transport: | ||
| name: docker | ||
|
|
||
| provisioner: | ||
| name: dummy | ||
| name: cinc_infra | ||
| install_strategy: skip | ||
|
|
||
| verifier: | ||
| name: cinc_auditor | ||
|
|
||
| platforms: | ||
| - name: amazonlinux-2 | ||
| - name: ubuntu-20.04 | ||
| - name: almalinux-8 | ||
| - name: almalinux-9 | ||
| - name: almalinux-10 | ||
| - name: amazonlinux-2023 | ||
| - name: ubuntu-22.04 | ||
| - name: ubuntu-24.04 | ||
| - name: ubuntu-26.04 | ||
| - name: fedora-latest | ||
| driver: | ||
| provision_command: | ||
| - yum install libxcrypt-compat -y | ||
| - curl -L https://www.chef.io/chef/install.sh | bash | ||
| - name: centos-stream-9 | ||
| driver: | ||
| image: dokken/centos-stream-9 | ||
| - name: oraclelinux-7 | ||
| - name: centos-stream-10 | ||
| driver: | ||
| image: dokken/centos-stream-10 | ||
| - name: oraclelinux-8 | ||
| - name: oraclelinux-9 | ||
| - name: oraclelinux-10 | ||
| - name: rockylinux-8 | ||
| - name: rockylinux-9 | ||
| - name: debian-12 | ||
| - name: opensuse-15 | ||
| - name: rockylinux-10 | ||
| driver: | ||
| image: dokken/rockylinux-10 | ||
| - name: debian-13 | ||
| - name: opensuse-16 | ||
| driver: | ||
| image: opensuse/leap:15 | ||
| image: opensuse/leap:16 | ||
| - name: dockerfile | ||
| driver: | ||
| username: dockerfile | ||
| password: dockerfile | ||
| dockerfile: test/Dockerfile | ||
| run_command: /sbin/init | ||
| - name: windows-2022 | ||
| driver: | ||
| image: mcr.microsoft.com/windows/servercore:ltsc2022 | ||
| provision_command: | ||
| - powershell -Command "Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12; iex ((New-Object System.Net.WebClient).DownloadString('https://omnitruck.cinc.sh/install.ps1')); Install-Project -Project cinc -Channel stable" | ||
| provisioner: | ||
| cinc_omnibus_root: 'C:\cinc-project\cinc' | ||
| verifier: | ||
| name: dummy # cinc_auditor uses WinRM for Windows but Windows containers don't have WinRM; verify via follow-up | ||
|
|
||
| suites: | ||
| - name: default | ||
| run_list: | ||
| - recipe[cinc_test::default] | ||
| verifier: | ||
| inspec_tests: | ||
| - test/integration/cinc/inspec | ||
| - name: docker-test | ||
| run_list: | ||
| - recipe[docker_test::default] | ||
| attributes: | ||
| docker_test: | ||
| revision: <%= `git rev-parse HEAD` %> | ||
| - name: no_build_context | ||
| run_list: | ||
| - recipe[cinc_test::default] | ||
| driver: | ||
| build_context: false | ||
| - name: capabilities | ||
| includes: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] | ||
| run_list: | ||
| - recipe[cinc_test::default] | ||
| driver: | ||
| provision_command: | ||
| - curl -L https://www.chef.io/chef/install.sh | bash | ||
| - apt-get install -y net-tools | ||
| cap_drop: | ||
| - NET_ADMIN | ||
| - name: arm64 | ||
| run_list: | ||
| - recipe[cinc_test::default] | ||
| driver: | ||
| docker_platform: linux/arm64 | ||
| - name: amd64 | ||
| run_list: | ||
| - recipe[cinc_test::default] | ||
| driver: | ||
| docker_platform: linux/amd64 | ||
| - name: inspec | ||
| driver: | ||
| provision_command: true | ||
| verifier: | ||
| name: inspec | ||
| run_list: | ||
| - recipe[cinc_test::default] |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this if we're using cinc stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into issues where cinc_auditor was still installing inspec and running inspec under the hood. This caused the license error on verify phase. We need to do a deeper dive and verify kitchen-cinc auditor is using cinc-auditor and there are no dependencies on inspec or inspec-core.