Skip to content

docs: reconcile audit trail and fix stale references before mainnet launch - #3

Merged
thecaphimself merged 1 commit into
mainfrom
docs/pre-launch-audit-cleanup
Jul 23, 2026
Merged

docs: reconcile audit trail and fix stale references before mainnet launch#3
thecaphimself merged 1 commit into
mainfrom
docs/pre-launch-audit-cleanup

Conversation

@HAPPYS1NGH

@HAPPYS1NGH HAPPYS1NGH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Changes

  • README Security section pointed at a deleted internal-review doc — now links the still-live external-audit-response and the two new automated scan reports (2026-07-22-1dollar-audit-report.md, 2026-07-22-nethermind-audit-agent-report.pdf), fixing a dead link.
  • RUNBOOK.md referenced docs/STATUS.md twice — that file has never existed in the repo's history — dangling references removed and replaced with real pointers (docs/security/, README's Contracts table).
  • packages/contracts/.env.example pointed at "Task 12" (not in this repo) for how to verify Safe addresses — now points at RUNBOOK §4, which has that exact guidance.
  • Terms of Service claimed "THE ESCROW CONTRACT HAS BEEN AUDITED" — overstated the actual status (internal review + AI scans, no manual third-party audit) — reworded to be accurate, since this is a real legal claim on a page live users see before depositing ETH.
  • Risk Disclosure page linked "externally audited" straight to the AI-scan vendor — that vendor's own report explicitly disclaims being used to represent the project as audited to the public — reworded to describe what was actually done and link the public reports instead.
  • Staged the two doc deletions (docs/history/coffer-product-spec-v1.md, the superseded docs/security/2026-07-12-cofferescrow-audit.md) that were sitting unstaged in the working tree, and the two new audit-report additions, so the docs/security folder actually reflects the current audit trail.

Notes

  • Docs-only PR by design — this does not touch the smart contract. Both new scan reports flag an unresolved Medium-severity finding in the currently-deployed escrow (a per-address, not per-pool, re-arm guard); that's a separate decision/PR, tracked outside this change.
  • apps/web verification: couldn't run pnpm install/tsc in this environment — local pnpm minimum-release-age policy rejects several lockfile entries unrelated to this change, and node_modules isn't installed here. The two .tsx edits are copy-only string changes inside existing JSX (no new imports/logic); diffs reviewed by hand for balanced JSX.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Q8Zfz426LiMJF9LMd9py8M

…aunch

Two new automated security scans landed in docs/security/ alongside a
deleted internal-review doc and a deleted historical product spec; the
surrounding docs and legal copy hadn't caught up. Broken/dead references
fixed, and audit-status claims brought in line with what's actually true:
internal review + AI-driven scans, no formal manual audit yet.

- README: drop dead link to the deleted internal-review doc, point at the
  external-audit-response and the two new scan reports instead.
- RUNBOOK: remove references to docs/STATUS.md, which never existed.
- contracts/.env.example: replace dangling "Task 12" reference with the
  actual RUNBOOK section that has the instructions.
- Terms/Risk Disclosure pages: "THE ESCROW CONTRACT HAS BEEN AUDITED" and
  "externally audited" (linking directly to the scan vendor) overstated
  the actual status and contradicted the AI-scan providers' own
  disclaimers against being cited as an audit to the public.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q8Zfz426LiMJF9LMd9py8M
@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
coffer-web Ready Ready Preview, Comment Jul 22, 2026 2:39pm
ens-diamonds Ready Ready Preview, Comment Jul 22, 2026 2:39pm

@thecaphimself
thecaphimself merged commit bd19977 into main Jul 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants