refactor: update teleop after buffer changes in tbp.monty - #7
Draft
ramyamounir wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the teleop plotter after the changes proposed in
tbp.montyPR#1051. This PR should not be merged until the monty changes are fully merged.The biggest change is that the locations are now represented differently in the LM buffer, so some of the helper functions have changed to compute a validity mask for input channels. This mask filters which rows in the buffer to use for each channel. There are a few more minor changes (e.g., changing renaming
get_current_mlhto_get_current_mlh), but nothing major.FYI @nielsleadholm