docs(proofs): clarify verification scope of attestation and proof verification - #243
Draft
emostov wants to merge 1 commit into
Draft
docs(proofs): clarify verification scope of attestation and proof verification#243emostov wants to merge 1 commit into
emostov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs-only change to
proofs/src/lib.rs(rustdoc comments; no behavior changes):parse_and_verify_aws_nitro_attestation/parse_and_verify_der_attestation: add warnings that these verify AWS Nitro PKI/COSE authenticity only and do not validate PCR identity,user_data, or manifest policy against expected/pinned values.verify(app_proof, boot_proof): document its actual scope (AWS attestation, envelope approval self-consistency, manifest/user_data linkage, ephemeral-key linkage, PCR0-3/PCR17 vs the supplied manifest) and warn that the supplied manifest contents, manifest-set members, and threshold are NOT compared to an independently pinned Turnkey trust anchor.unsafe_attestation_doc_from_der(attestation_doc_from_der->parse_and_verify_der_attestation).All warnings point to https://github.com/tkhq/qos for the canonical verification checks.
Verification