Validate provider for non-PKCE OAuth responses - #1359
Open
samsamtrum wants to merge 1 commit into
Open
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d109eae:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates the OAuth
providerstate for non-PKCE popup responses, matching the existing validation already applied to PKCE providers.Why
parseOAuthResponse(url, expectedProvider)currently rejects PKCE popup responses when the provider in state does not matchexpectedProvider, but non-PKCE providers only require anid_token.That means a popup handler expecting Google can accept a hash whose state says another provider, as long as an
id_tokenis present. This can route a mismatched OAuth response through the wrong popup handler.This change makes non-PKCE validation require both:
id_tokenis presentprovider === expectedProviderand adds a regression test for the mismatch case.