React Native in workspaces: Start with oauth-cross-platform/mobile [1/N] - #1399
React Native in workspaces: Start with oauth-cross-platform/mobile [1/N]#1399janjakubnanista wants to merge 9 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 45bd9db:
|
33a09fa to
7793b79
Compare
6e25fc6 to
8ca6c05
Compare
…the workspace [2/N]
8ca6c05 to
25875f6
Compare
25875f6 to
f78e0fe
Compare
| "react-native": "0.81.4", | ||
| "react-native-gesture-handler": "~2.28.0", | ||
| "react-native-inappbrowser-reborn": "^3.7.1", | ||
| "react-native-safe-area-context": "~5.6.0", |
There was a problem hiding this comment.
Curious why these new dev dependencies were added, do we use them in examples only? Why add them at the package level?
| ? window.location.hostname | ||
| : DeviceInfo.getApplicationName() || | ||
| DeviceInfo.getBundleId() || | ||
| "mobile-app"; |
There was a problem hiding this comment.
I don't believe this is breaking but anyone that does rely on passkey names being named based on their device app name will need to update their config with their app name.
Not a huge deal but is there a reason why react-native-device-info needs to be removed? Is that the package that blocks us from using @turnkey/react-native-wallet-kit in our workspace?
There was a problem hiding this comment.
react-native-device-info does not play nice with expo - you would need to create a custom build for it to run (which is out of scope for an example that does not have a build step). Expo, in a managed workflow, uses expo-device rather than react-native-device-info. So removing this dependency not only fixes this issue but makes this code compatibility a bit wider
| @@ -5,14 +5,14 @@ packages: | |||
| - "!examples/demos/with-react-native-wallet-kit/**" | |||
There was a problem hiding this comment.
Will it be possible to remove with-react-native-wallet-kit from the workspace block with these changes as well? That would be amazing
There was a problem hiding this comment.
Yeah I am going one by one though
Summary & Motivation
Until now we kept the
react-nativeexamples out of thepnpmworkspaces. This PR:TurnkeyProviderin@turnkey/react-native-wallet-kitso that it does not depend onreact-native-device-info(incompatible withexpo). This is a backwards-compatible change as it only adds an optional property. MissingdevDependencieshave also been added, just as a little cleanup (until now the package would rely on these implicitly)expo& Runsnpx expo-doctorinoauth-cross-platform/mobiletypecheckcommand and fixes some smaller issuesHow I Tested These Changes
Locally on an iOS simulator + CI for typecheck
Did you add a changeset?
Yes, to
@turnkey/react-native-wallet-kit