codegen fix: destructure generateAppProofs out of ...rest - #1462
Open
besler613 wants to merge 1 commit into
Open
codegen fix: destructure generateAppProofs out of ...rest#1462besler613 wants to merge 1 commit into
generateAppProofs out of ...rest#1462besler613 wants to merge 1 commit into
Conversation
besler613
marked this pull request as ready for review
August 3, 2026 17:08
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2ab084:
|
besler613
changed the title
generateAppProofs out of ...rest
besler613
force-pushed
the
brianesler/codegen-destructure-generateAppProofs
branch
from
August 3, 2026 18:29
6ab48c0 to
f2ab084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR corrects a bug in the codegen across all three packages. Specifically:
generateAppProofsinto parameters via...rest/...parameterseven though it belongs only at the top level of the request.generateAppProofsseparately before building parameters, and pass it only as a top-level field on the wire request (including stamp methods).How I Tested These Changes
Did you add a changeset?
N/A